Ensure that FileInfo return values as required by its phpdoc.#4001
Merged
Conversation
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
requested review from
LukasReschke,
blizzz,
icewind1991,
nickvergessen,
rullzer and
schiessle
|
@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @nickvergessen and @LukasReschke to be potential reviewers. |
rullzer
approved these changes
Mar 23, 2017
icewind1991
approved these changes
Mar 23, 2017
nickvergessen
requested changes
Mar 23, 2017
| * @return int | ||
| * Get FileInfo ID or null in case of part file | ||
| * | ||
| * @return int/null |
| */ | ||
| public function getId() { | ||
| return $this->data['fileid']; | ||
| return isset($this->data['fileid']) ? intval($this->data['fileid']) : null; |
Member
There was a problem hiding this comment.
EA complains to use (int) instead.
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
approved these changes
Mar 23, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @icewind1991